Wow, I'm actually surprised to see such cynicism regarding the pedagogical theory...
...snip...
When you evaluate your students on their ability to perform well on tests you fail to consider the reality that many of those students will memorize what they need to pass and then forget it. They have no passion for learning in and of itself. It is reduced to explicit instruction only.
...snip...
The goal should be one that is focused on teaching students how to learn rather than what to learn. When you teach a student how to learn they can learn anything.
i think (some of) what you interpret as cynicism is in fact experience with failed new-fanged methods; insight based on a deeper, if unstructured, pedagogical theory more consistent with experience.
"teaching for the test" fails to give students the ability to use tools for the reason you mention. but to grant that point does not lead to "teaching students how to learn rather than what to learn" in the way you suggest leads them to master the tools. in areas where both proficiency with the tools and creative insight is required to make real progress, there is no evidence that "teaching students how to learn" provides any pedagogical guidance whatsoever to the teacher.
the apprenticeship approach cannot be mass deployed, but remains the best i've seen. there is nothing exciting about learning the tools, be they integration by parts or practicing scales. i agree with you that it is easier to put in the time if you are motivated to reach some higher goal, but often a teacher needs to teach what to learn as well as how (and ideally enthuse by exposing them to a "why" that the students value).
in large part, of course, i am just echoing the more concise post by Sam H (thanks sam).